Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34491?usp=email )
Change subject: ASCI: Add group receive and transmit mode support to RR layer ......................................................................
Patch Set 1:
(5 comments)
File src/host/layer23/src/mobile/gsm48_rr.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11164): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/0a85918b_6c805ed3 PS1, Line 510: while((msg = msgb_dequeue(&rr->downqueue))) space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11164): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/181b3ab1_a88dd160 PS1, Line 1529: if (bitvec_get_bit_high(&bv) == H) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11164): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/47e0d30d_0665a654 PS1, Line 1963: /* Note: Other informations are not used. */ 'informations' may be misspelled - perhaps 'information'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11164): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/2be13072_755c2368 PS1, Line 5501: reject: labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-11164): https://gerrit.osmocom.org/c/osmocom-bb/+/34491/comment/a15c330a_469edcb7 PS1, Line 6389: /* Leave uplink, wait for uplink beeing free, channel release or channel/link failure. */ 'beeing' may be misspelled - perhaps 'being'?