Attention is currently required from: dexter, fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/36973?usp=email )
Change subject: add pySim.esim.es9p with definitions of the ES9+ HTTP Interface ......................................................................
Patch Set 4:
(3 comments)
File pySim/esim/es9p.py:
https://gerrit.osmocom.org/c/pysim/+/36973/comment/5ac68f3e_8cec78e7 PS4, Line 21: import json : from da
not used in this module
Done
https://gerrit.osmocom.org/c/pysim/+/36973/comment/627b7a55_2b13fd5d PS4, Line 32: param
cosmetic: class names should follow CamelCase naming
mh, I'm more using this 'class' here as a group, in a sense like a sub-module. It's also done like this in es2p.py that's already in master. So if we'd change this, it would have to be done consistently in a separate patch.
https://gerrit.osmocom.org/c/pysim/+/36973/comment/7939c30a_2bd12e27 PS4, Line 153: FIXME HACK
what's wrong here?
well, it disables SSL certificate validation ;) Works for testing, but is of course completely insecure.