Attention is currently required from: laforge, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-iuh/+/38946?usp=email )
Change subject: iu_client: add ranap_iu_page_cs2/ranap_iu_page_ps2 ......................................................................
Patch Set 12:
(4 comments)
File src/iu_client.c:
https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/0fdb0a44_fa7f4a49?usp=... : PS10, Line 869: /* find all RNCs which are serving this RNC */
Acknowledged
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/3c8e47ab_9403d5fd?usp=... : PS10, Line 878: osmo_rnc_id_name(&rnc->rnc_id),
this indentation may be wrong.
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/119f633d_bbb4a27c?usp=... : PS10, Line 883: } else if (!is_ps && !osmo_lai_cmp(&entry->rai.lac, &ra_id->lac)) {
this "else" can be removed in this line, simplifying logic.
Done
https://gerrit.osmocom.org/c/osmo-iuh/+/38946/comment/25943e12_be9f24e8?usp=... : PS10, Line 932: return iu_page2(imsi, tmsi, &rai, false);
Acknowledged
Done