Attention is currently required from: osmith, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33400 )
Change subject: Fix various uninitialized value errors ......................................................................
Patch Set 1:
(2 comments)
File src/gsm/gsm23236.c:
https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/1ea8fbac_133e5aa1 PS1, Line 490: struct osmo_nri_range add_range = {};
I don't really see a problem with not initializing it, unless osmo_nri_parse_range() requires the fi […]
It's not required to be zero-initialized. The point is that `osmo_nri_parse_range()` inits fields `add_range.{first,last}`, but not `add_range.entry`. The later is initialized by `osmo_nri_ranges_add()` below.
https://gerrit.osmocom.org/c/libosmocore/+/33400/comment/51f14b1a_ea5459a3 PS1, Line 496: if (added_range)
imho this should be moved after the if in line 499.
Ack, this should do the trick.