17 Jun
2023
17 Jun
'23
8:12 a.m.
Attention is currently required from: pespin, daniel.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/33341 )
Change subject: osmo_io: Make name optional, add _set_name() API ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Adding Harald because in our early discussions we agreed to have the name mandatory in osmo_io. […]
I think the ability to change it is definitely good. Not sure if we should make it optional upon creation. Not sure what we gain by that, other than more objects in our code we don't have proper context for when logging or introspecting.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/33341
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If2772a3ccaa98616e0189862a49ab0243435e343
Gerrit-Change-Number: 33341
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel dwillmann@sysmocom.de
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Attention: daniel dwillmann@sysmocom.de
Gerrit-Comment-Date: Sat, 17 Jun 2023 06:12:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel dwillmann@sysmocom.de
Gerrit-MessageType: comment