Attention is currently required from: fixeria, lynxis lazus, osmith.
pespin has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/osmo-sgsn/+/40988?usp=email )
Change subject: Introduce iu_rnc FSM
......................................................................
Patch Set 3:
(1 comment)
File src/sgsn/iu_rnc_fsm.c:
https://gerrit.osmocom.org/c/osmo-sgsn/+/40988/comment/866c1370_8489c384?us… :
PS3, Line 126: #define LEGACY_BEHAVIOR
Is there a plan for removing the legacy behavior,
maybe write an issue about it and point to it here […]
This is basically the same
ifdef we already have in osmo-msc ran_peer_fsm.
I preferred keeping it in sync with what we do in osmo-msc, specially since changing to
the other behavior would mean more behavioral changes I'm tyring to avoid now.
so my opinion is leave it like I presented and let everything stabilize, and we can look
at this later once we find something unoptimal or problematic when running it and get some
specific report.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-sgsn/+/40988?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I18b7803500163e78ff6a684095194174b0fb6ee1
Gerrit-Change-Number: 40988
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 02 Sep 2025 12:09:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>