Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email )
Change subject: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES ......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/core/soft_uart.h:
https://gerrit.osmocom.org/c/libosmocore/+/35045/comment/feaa2f0c_67944841 PS2, Line 78: number of received UART frames for OSMO_SUART_RX_MODE_N_FRAMES; UART : * will flush receive buffer via the receive call-back after indicated number : * of UART frames had been received. * how is this different from the existing behavior if you'd simply make the rx buffer size == rx_n_uart_frames?
The original code was written in a way that *normally* you would call the call-back whenever the buffer is full, but in casese that takes too long, we use the timeout as a fall-back.