Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email ) Change subject: [WIP] soft_uart: implement OSMO_SUART_RX_MODE_N_FRAMES ...................................................................... Patch Set 2: (1 comment) File include/osmocom/core/soft_uart.h: https://gerrit.osmocom.org/c/libosmocore/+/35045/comment/feaa2f0c_67944841 PS2, Line 78: number of received UART frames for OSMO_SUART_RX_MODE_N_FRAMES; UART : * will flush receive buffer via the receive call-back after indicated number : * of UART frames had been received. * how is this different from the existing behavior if you'd simply make the rx buffer size == rx_n_uart_frames? The original code was written in a way that *normally* you would call the call-back whenever the buffer is full, but in casese that takes too long, we use the timeout as a fall-back. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35045?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib3249a06c84f3ddb2723d0787db51873c4707d81 Gerrit-Change-Number: 35045 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 16 Nov 2023 15:30:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment