Attention is currently required from: laforge, lynxis lazus, osmith, pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email )
Change subject: config: Set pfcp_net_inst_* fields as strings
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
@vyanitskiy@sysmocom. […]
Yes, see my other comment.
File src/erab_fsm.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461/comment/0a4acf86_d49c4... :
PS2, Line 88: bin_fqdn() :: [bin_fqdn_label()].
:
I believe this type spec is wrong and this is making the dialyzer unhappy. At the end of `enc_net_inst/1` you're calling `list_to_binary/1`, which is expected to return a `binary()`, not a list.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/41461?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I7c2da02945829066d317100556e09e55483bd7e7
Gerrit-Change-Number: 41461
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-Attention: osmith
osmith@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Comment-Date: Tue, 18 Nov 2025 17:09:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin
pespin@sysmocom.de
