Attention is currently required from: neels.
laforge has posted comments on this change by neels. (
https://gerrit.osmocom.org/c/pysim/+/40341?usp=email )
Change subject: es2p.py: also allow 18 digit ICCID
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
why would 18 digits be permitted? According to the wikpedia "SIM card" page,
*In practice, this means that on GSM cards there are 20-digit (19+1) and 19-digit (18+1)
ICCIDs in use*.
E.118 actually doesn't really specify a minimum length. It just states that the IIN at
the beginning is variable-length (max 7 digits) and there are a variable number of account
identification numbers following it up to the max. length of 19 digits. GSM Phase 1
violated that max-19 by using 20 digits.
So I think we should either keep it 19-or-20 digits [practical] or allow anything up to 20
digits [narrow reading of E.118 plus phase1 compat].
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/40341?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iaa6e710132e3f4c6cecc5ff786922f6c0fcfb54e
Gerrit-Change-Number: 40341
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 May 2025 09:12:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No