Attention is currently required from: dexter, jolly, laforge.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email )
Change subject: ta_control: Fix skip_block_num not reset when switching TS to PDCH
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File include/osmo-bts/ta_control.h:
https://gerrit.osmocom.org/c/osmo-bts/+/41790/comment/1a62dacf_03d38021?usp=... :
PS2, Line 6:
maybe remove the line break?
That's fine I say, it's not like there's tons of lines to compress 😊
File src/common/ta_control.c:
https://gerrit.osmocom.org/c/osmo-bts/+/41790/comment/1f6315b1_dba9cc09?usp=... :
PS2, Line 47: /* Trigger loop on first TA input: */
Maybe put this comment above the function? (I guess both assignments are required for the trigger)
No, only the one exactly below.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d
Gerrit-Change-Number: 41790
Gerrit-PatchSet: 2
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Fri, 09 Jan 2026 20:03:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter
pmaier@sysmocom.de
