Attention is currently required from: pespin, lynxis lazus.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/29907 )
Change subject: fsm: add ignore_invalid_event_mask bit-mask
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
I find it very difficult to write empty events in many
states (both in the in_event_mask and within […]
I am also sceptical regarding
this change, sorry.
* if we have misleading log messages, and users report them, it is good so the code can be
fixed. To me, any of those messages occuring during normal operation means that the FSM
hasn't been properly completed yet, and it should draw attention to the developer.
Ideally we wouldn't have to go via users, but developers would notice themselves, of
course.
* adding more and more "obscure options" ot the FSM makes it more and more
difficult to use it right.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/29907
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Id010ade76de83ccf428f2d18e9f85bcce1d1ea2c
Gerrit-Change-Number: 29907
Gerrit-PatchSet: 3
Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Fri, 28 Oct 2022 16:53:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-MessageType: comment