Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/30797 )
Change subject: rlcmac: add decoder and test vectors for IA Rest Octets
......................................................................
Patch Set 1:
(1 comment)
File tests/rlcmac/ts_44_018_test.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/30797/comment/790b6ccd_1ccd31b5
PS1, Line 63: static const char *testData[] = {
> static const char * array should probably be
static const char * const […]
See my message above. If you think this is really
important, it can be done in a separate patch.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/30797
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I39a29dc9b5b22ce4374ae33336696014e326d012
Gerrit-Change-Number: 30797
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 02 Jan 2023 12:51:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment