Attention is currently required from: fixeria.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-bts/+/38312?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed: Verified-1 by Jenkins Builder
Change subject: l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind() ......................................................................
l1sap: call csd_v110_rtp_decode() in l1sap_tch_rts_ind()
The problem with calling csd_v110_rtp_decode() from l1sap_rtp_rx_cb() is that we don't know in advance at which TDMA frame number the resulting TCH block is going to be scheduled/transmitted. This knowledge will be required in follow-up patches.
* In l1sap_rtp_rx_cb(): create an L1SAP msgb with the RTP payload unmodified (160 bytes), like we do for speech frames. * In l1sap_tch_rts_ind(): copy the RTP payload into a temporary buffer on stack and call csd_v110_rtp_decode(), re-using the L1SAP msgb as the output buffer.
This patch brings no functional changes, except that the DL RLP PDUs now how the correct TDMA frame number in GSMTAP output (was always 0).
Related: OS#6578 Change-Id: Idca6807b1e49b89072683b9f00ff4e7cee44cf33 --- M src/common/l1sap.c 1 file changed, 107 insertions(+), 101 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/12/38312/3