Attention is currently required from: neels, pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28993 )
Change subject: Update multiaddr helper ......................................................................
Patch Set 9:
(5 comments)
Patchset:
PS6:
We gain decrease of code duplication - we use the same function which is also used in other place in […]
Done
Patchset:
PS8:
the code added in https://gerrit.osmocom. […]
Done
Patchset:
PS9: Updated static helper instead of creating new function as requested in feedback.
File src/socket.c:
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/b561a406_fc5010a7 PS8, Line 208: * buf_len >= 2: (hostA|hostB|...|...)
(this doc is wrong)
Done
https://gerrit.osmocom.org/c/libosmocore/+/28993/comment/b064f7de_37eaf3a4 PS8, Line 211: {
if you use an implementation like this here, we don't need to add osmo_sockaddr_strs_to_str() at all […]
Done