Attention is currently required from: pespin. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared ......................................................................
Patch Set 14:
(5 comments)
This change is ready for review.
File src/libmsc/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/4b37e93c_e70e7273 PS7, Line 163: struct esme *esme = acl->esme->esme;
Not sure what doyouwin with this change here. In fact, it looks more confusing.
See the follow-up comment.
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/b5393444_d82d7513 PS7, Line 242: osmo_wqueue_clear(&esme->esme->wqueue);
Sound like you want to move this block to some API to free the "struct esme" and put it by the side […]
Yes, the common part is in "struct_esme" while the MSC-specific parts are in "struct osmo_esme" which now includes the link (*esme) to it.
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/91e052d1_e49d17ab PS7, Line 330: static int pack_and_send(struct esme *esme, uint32_t type, void *ptr)
IIUC this calls can go now to some other file containing "struct esme" APIs.
They will in a follow-up patch. I've decided to split renaming into separate patch to make it easier to review.
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/ea2debab_e0f654c2 PS7, Line 384: static int smpp_handle_gen_nack(struct osmo_esme *esme, struct msgb *msg)
this can be probably changed to "struct esme"
Done
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/dda4375e_653ef377 PS7, Line 864: osmo_fd_unregister(&esme->esme->wqueue.bfd);
THis can be moved to a "struct esme" API in a different file?
It'll be removed in follow-up patch as part of migration to libosmo-netif