5 Aug
2022
5 Aug
'22
5:44 p.m.
Attention is currently required from: pespin.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/28846 )
Change subject: Make esme struct shared
......................................................................
Patch Set 14:
(5 comments)
This change is ready for review.
File src/libmsc/smpp_smsc.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/4b37e93c_e70e7273
PS7, Line 163: struct esme *esme = acl->esme->esme;
Not sure what doyouwin with this change here. In fact,
it looks more confusing.
See the follow-up comment.
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/b5393444_d82d7513
PS7, Line 242: osmo_wqueue_clear(&esme->esme->wqueue);
Sound like you want to move this block to some API to
free the "struct esme" and put it by the side […]
Yes, the common part is
in "struct_esme" while the MSC-specific parts are in "struct
osmo_esme" which now includes the link (*esme) to it.
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/91e052d1_e49d17ab
PS7, Line 330: static int pack_and_send(struct esme *esme, uint32_t type, void *ptr)
IIUC this calls can go now to some other file
containing "struct esme" APIs.
They will in a follow-up patch. I've
decided to split renaming into separate patch to make it easier to review.
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/ea2debab_e0f654c2
PS7, Line 384: static int smpp_handle_gen_nack(struct osmo_esme *esme, struct msgb *msg)
this can be probably changed to "struct
esme"
Done
https://gerrit.osmocom.org/c/osmo-msc/+/28846/comment/dda4375e_653ef377
PS7, Line 864: osmo_fd_unregister(&esme->esme->wqueue.bfd);
THis can be moved to a "struct esme" API in
a different file?
It'll be removed in follow-up patch as part of migration to
libosmo-netif
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28846
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I8f7ac2c00d16660925dd0b03aa1a0973edf9eb70
Gerrit-Change-Number: 28846
Gerrit-PatchSet: 14
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Aug 2022 15:44:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment