Attention is currently required from: pespin.

View Change

5 comments:

• File src/libmsc/smpp_smsc.c:

  • Patch Set #7, Line 163: struct esme *esme = acl->esme->esme;

    Not sure what doyouwin with this change here. In fact, it looks more confusing.

    See the follow-up comment.

  • Patch Set #7, Line 242: osmo_wqueue_clear(&esme->esme->wqueue);

    Sound like you want to move this block to some API to free the "struct esme" and put it by the side […]

    Yes, the common part is in "struct_esme" while the MSC-specific parts are in "struct osmo_esme" which now includes the link (*esme) to it.

  • Patch Set #7, Line 330: static int pack_and_send(struct esme *esme, uint32_t type, void *ptr)

    IIUC this calls can go now to some other file containing "struct esme" APIs.

    They will in a follow-up patch. I've decided to split renaming into separate patch to make it easier to review.

  • Patch Set #7, Line 384: static int smpp_handle_gen_nack(struct osmo_esme *esme, struct msgb *msg)

    this can be probably changed to "struct esme"

    Done

  • Patch Set #7, Line 864: osmo_fd_unregister(&esme->esme->wqueue.bfd);

    THis can be moved to a "struct esme" API in a different file?

    It'll be removed in follow-up patch as part of migration to libosmo-netif

To view, visit change 28846. To unsubscribe, or for help writing mail filters, visit settings.