Change in osmo-pcu[master]: fix pcu_l1if_tx_ptcch(): do not send empty blocks to GSMTAP

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/29539 ) Change subject: fix pcu_l1if_tx_ptcch(): do not send empty blocks to GSMTAP ...................................................................... fix pcu_l1if_tx_ptcch(): do not send empty blocks to GSMTAP This makes no sense and confuses Wireshark, so it shows malformed packets. We are not sending empty PDTCH blocks to GSMTAP either. Change-Id: Ic7b6aca4f3af43a6fd47d033c950c711164685a4 Related: SYS#6045 --- M src/pcu_l1_if.cpp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index 221a1f7..67e4de5 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -244,7 +244,7 @@ uint32_t fn, uint8_t block_nr, uint8_t *data, size_t data_len) { - if (the_pcu->gsmtap_categ_mask & (1 << PCU_GSMTAP_C_DL_PTCCH)) + if (data_len && the_pcu->gsmtap_categ_mask & (1 << PCU_GSMTAP_C_DL_PTCCH)) gsmtap_send(the_pcu->gsmtap, arfcn, ts, GSMTAP_CHANNEL_PTCCH, 0, fn, 0, 0, data, data_len); #ifdef ENABLE_DIRECT_PHY if (bts->trx[trx].fl1h) { -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/29539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ic7b6aca4f3af43a6fd47d033c950c711164685a4 Gerrit-Change-Number: 29539 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-MessageType: merged