Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30111 )
Change subject: fix sdp_msg_to_sdp_str(), never add fmtp for unset codec ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/libmsc/sdp_msg.c:
https://gerrit.osmocom.org/c/osmo-msc/+/30111/comment/4309fc95_0ff23a4f PS1, Line 271: if (!sdp_audio_codec_is_set(codec))
Isn't sdp_audio_codec_is_set() implemented by checking codec->subtype_name[0] like before? what's ch […]
the previous code did not check if codec->subtype was a valid pointer at all, and unconditionally dereferenced it. The new code is now checkign for a valid pointer, and whether the first character is non-NUL.