10 Oct
2025
10 Oct
'25
2 p.m.
Attention is currently required from: fixeria, jolly, laforge, lynxis lazus, neels, osmith.
matanp has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email )
Change subject: vlr: Stop silent call before deduping subscribers ......................................................................
Patch Set 2:
(1 comment)
File src/libvlr/vlr.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41131/comment/bfa95983_964bf63a?usp=... : PS1, Line 651: gsm_silent_call_stop(
Good point. If there's no silent call going on, `gsm_silent_call_stop()` will log errors...
I added a check to make sure we stop only ongoing transactions
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If23f8b0e42d4a3a8bf1c8f5ca81b045834b6cccd
Gerrit-Change-Number: 41131
Gerrit-PatchSet: 2
Gerrit-Owner: matanp matan1008@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly andreas@eversberg.eu
Gerrit-Reviewer: laforge laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus lynxis@fe80.eu
Gerrit-Reviewer: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: osmith osmith@sysmocom.de
Gerrit-Attention: jolly andreas@eversberg.eu
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Attention: fixeria vyanitskiy@sysmocom.de
Gerrit-Attention: lynxis lazus lynxis@fe80.eu
Gerrit-Comment-Date: Fri, 10 Oct 2025 14:00:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly andreas@eversberg.eu
Comment-In-Reply-To: fixeria vyanitskiy@sysmocom.de