Attention is currently required from: jolly, neels, laforge, fixeria, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/31417 )
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload ......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/4524c698_738e0e8c PS8, Line 16: are accepted.
I am not clear here, there is code in this patch that converts the HR format to match the BTS, and t […]
Agree, I also mentioned that in my last review.
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/3b969c1e_8f6db2dc PS8, Line 1274: /* BTS flags specify that RFC 5993 (and not ETSI TS 101.318) is understood by lower layers */
I agree with the patch here, to keep the logic of this function uniform: "return false if anything i […]
Ack
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/9681107a_8c3f512f PS8, Line 1952: * formats are supported (either by setting both or none of the flags), no conversion will be carried out. */
need clarification: is this patch converting or rejecting?
Ack