Attention is currently required from: jolly, neels, laforge, fixeria, dexter.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31417
)
Change subject: l1sap: Accept RFC5993 and TS 101.318 HR GSM payload
......................................................................
Patch Set 8:
(3 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/4524c698_738e0e8c
PS8, Line 16: are accepted.
I am not clear here, there is code in this patch that
converts the HR format to match the BTS, and t […]
Agree, I also mentioned that in
my last review.
File src/common/l1sap.c:
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/3b969c1e_8f6db2dc
PS8, Line 1274: /* BTS flags specify that RFC 5993 (and not ETSI TS 101.318) is
understood by lower layers */
I agree with the patch here, to keep the logic of this
function uniform: "return false if anything i […]
Ack
https://gerrit.osmocom.org/c/osmo-bts/+/31417/comment/9681107a_8c3f512f
PS8, Line 1952: * formats are supported (either by setting both or none of the flags),
no conversion will be carried out. */
need clarification: is this patch converting or
rejecting?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31417
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I453562da412fde5b928bd2b588129c58ec8e2a7e
Gerrit-Change-Number: 31417
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 04 May 2023 17:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment