Attention is currently required from: jolly, neels, laforge, fixeria, dexter.

View Change

3 comments:

• Commit Message:

  • Patch Set #8, Line 16: are accepted.

    I am not clear here, there is code in this patch that converts the HR format to match the BTS, and t […]

    Agree, I also mentioned that in my last review.

• File src/common/l1sap.c:

  • Patch Set #8, Line 1274: /* BTS flags specify that RFC 5993 (and not ETSI TS 101.318) is understood by lower layers */

    I agree with the patch here, to keep the logic of this function uniform: "return false if anything i […]

    Ack

  • Patch Set #8, Line 1952: * formats are supported (either by setting both or none of the flags), no conversion will be carried out. */

    need clarification: is this patch converting or rejecting?

    Ack

To view, visit change 31417. To unsubscribe, or for help writing mail filters, visit settings.