Attention is currently required from: Hoernchen, osmith.
Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330?usp=email )
Change subject: fw source: force reformat once and for all ......................................................................
Patch Set 2:
(3 comments)
File sysmoOCTSIM/dfu_descriptors.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/9c870936_7ef... : PS2, Line 30: #define DFURT_IF_DESCRIPTOR_STRUCT \ macros should not use a trailing semicolon
File sysmoOCTSIM/talloc.h:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/d09cbf92_c6d... : PS2, Line 880: void *talloc_pooled_object(const void *ctx, #type, unsigned num_subobjects, size_t total_subobjects_size); function definition argument 'type' should also have an identifier name
File sysmoOCTSIM/talloc.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42330/comment/9e28b42b_84f... : PS2, Line 251: #define TC_UNDEFINE_GROW_CHUNK(_tc, _new_size) \ Single statement macros should not use a do {} while (0) loop