pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/35070?usp=email )
Change subject: xua + ipa: Add support for I/O in OSMO_IO mode ......................................................................
Patch Set 9: Code-Review+1
(2 comments)
File src/osmo_ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/ccf6a228_251a55c8 PS9, Line 867: if (rc < 0) { How is this supposed to happen now with osmo_io? It's still not clear to me. Scenarario is: we have a server-side SCTP/TCP ASP whose socket suddenly becomes death (eg. tcp timeout). Where are we getting this notification now? Where are we calling osmo_stream_srv_destroy()?
AFAIU it's done through ss7_asp_xua_srv_conn_closed_cb(), but I don't see osmo_stream_srv_destroy() being called there. Is the call to osmo_stream_srv_destroy() done now automatically from within osmo_stream_srv?
I'm not saying it's wrong, I just want to make sure we have no regressions here.
File src/osmo_ss7_xua_srv.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/35070/comment/2c49a430_c2bfac37 PS9, Line 83: switch (oxs->cfg.proto) { (Not to be done now, but we should ideally move some of this logic to a new function in _asp.c since most of this is done on the srv object).