Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35467?usp=email )
Change subject: pseudotalloc: add talloc_memdup(), use it in talloc_strdup()
......................................................................
Patch Set 4:
(1 comment)
File src/pseudotalloc/pseudotalloc.c:
https://gerrit.osmocom.org/c/libosmocore/+/35467/comment/7843356f_230b4745
PS4, Line 61:
(should it check for size == 0? ... […]
I
don't think we should check for every possible mistake the API user can make.
This 'pseudo' implementation is not aiming to be 100% complete either...
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35467?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ifcf377c3496a9e75404932a1aaba7d74888cf4cf
Gerrit-Change-Number: 35467
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 03 Jan 2024 17:18:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Gerrit-MessageType: comment