Jenkins Builder has posted comments on this change by dexter. (
https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email )
Change subject: pcu_sock: do not receive a TXT ind. with PCU_VERSION for a specific BTS
......................................................................
Patch Set 1:
(2 comments)
File src/osmo-bsc/pcu_sock.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20251):
https://gerrit.osmocom.org/c/osmo-bsc/+/38957/comment/dc65aebc_1b4e6d5a?usp… :
PS1, Line 694: LOGP(DPCU, LOGL_ERROR, "Unknown TXT_IND type %u
received\n",
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-20251):
https://gerrit.osmocom.org/c/osmo-bsc/+/38957/comment/d18662e6_831fc8e1?usp… :
PS1, Line 712: #define ENSURE_BTS_OBJECT() \
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else
logic defects
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/38957?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3fbf5430db8b8ea29efb147bd162706990453fc5
Gerrit-Change-Number: 38957
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 26 Nov 2024 16:45:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No