Attention is currently required from: osmith.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email )
Change subject: s1gw: add TC_e_rab_setup
......................................................................
Patch Set 3:
(2 comments)
File s1gw/S1GW_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245/comment/7d3efa6c_a2d9…
PS3, Line 176: S1AP_CONN
is S1AP_CONN and S1AP_ENB swapped in
f_ConnHdlr_rx_s1ap_from_enb and f_ConnHdlr_rx_s1ap_from_mme?
Yes, and this is
correct. The testsuite emulates both eNB (client, connecting to S1GW) and MME (server,
accepting connections from S1GW). When we expect to receive something from eNB, we receive
on `S1AP_CONN` (MME). Likewise, when we expect to receive something from the MME, we
receive on `S1AP_ENB` (eNB). S1GW is just a proxy.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245/comment/aa7319ec_cd15…
PS3, Line 181: setverdict(fail, "Rx unexpected S1AP PDU: ", pdu);
maybe note from eNB / MME here and below?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37245?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I94eb8cac4b5659c0f6f1bb248a80692b8cf84b6f
Gerrit-Change-Number: 37245
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Jun 2024 10:59:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment