Change in osmo-bsc[master]: SI13: Make sure egprs_supported field is always updated

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27538 ) Change subject: SI13: Make sure egprs_supported field is always updated ...................................................................... SI13: Make sure egprs_supported field is always updated If "bts->gprs.mode" was changed dynamically at runtime (VTY or CTRL), it could happen that the egprs_supported was kept as "1" if the dynamic change was EGPRS->GPRS. In summary, if EGPRS support was set, it couldn't be unset until BSC was restarted. Related: SYS#5894 Change-Id: Id2c2319044da474642c4cc710baa27cfee4fb592 --- M src/osmo-bsc/system_information.c 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/src/osmo-bsc/system_information.c b/src/osmo-bsc/system_information.c index a6e1e1c..9aae7bd 100644 --- a/src/osmo-bsc/system_information.c +++ b/src/osmo-bsc/system_information.c @@ -1306,13 +1306,16 @@ switch (bts->gprs.mode) { case BTS_GPRS_EGPRS: + si_info.gprs_ind.present = 1; si13_default.cell_opts.ext_info.egprs_supported = 1; - /* fallthrough */ + break; case BTS_GPRS_GPRS: si_info.gprs_ind.present = 1; + si13_default.cell_opts.ext_info.egprs_supported = 0; break; case BTS_GPRS_NONE: si_info.gprs_ind.present = 0; + si13_default.cell_opts.ext_info.egprs_supported = 0; break; } 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27538 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id2c2319044da474642c4cc710baa27cfee4fb592 Gerrit-Change-Number: 27538 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged