Attention is currently required from: jolly, laforge, neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35392?usp=email )
Change subject: Add LLC and HLC information to MNCC interface definiton ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
@vyanitskiy@sysmocom. […]
Neels: I think you're right. Changed to CR-1.
The problem with adding new fields is that we enlarge the MNCC PDU. While it may be fine sending a larger PDU to a peer; we may have problems when a peer is sending a shorter PDU than we expect.
If you're sure this works fine and:
* an older version of osmo-sip-connector can still "talk" to recent osmo-msc, * an older version of osmo-msc can still "talk" to recent osmo-sip-connector,
as long as they "speak" the same MNCC protocol version, we must be absolutely sure that this would not cause any fallout for the respective TTCN-3 testsuites.