Attention is currently required from: osmith, fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmocom-bb/+/32414 )
Change subject: layer23: modem: Set on tun the IP address received during PDP Ctx Act
Accept
......................................................................
Patch Set 1:
(2 comments)
File src/host/layer23/src/modem/sm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/32414/comment/81d3a787_3d430a92
PS1, Line 70: get_value_string(gsm48_gsm_cause_names,
sm_prim->smreg.pdp_act_cnf.rej.cause));
missing return?
Ack
https://gerrit.osmocom.org/c/osmocom-bb/+/32414/comment/76b15acc_f5fd687a
PS1, Line 86: [FIXME: IPv6 not yet supported!
with this you mean elsewhere in the osmocom-bb code, I
guess? just asking to be sure because you do […]
IPv6 it's a bit more complex
than just setting the IP address, since the address provided here is a locallink one only
used to start SLACC procedure, which is something that will be left for later for sure, at
least until we have IPv4 fully working.
--
To view, visit
https://gerrit.osmocom.org/c/osmocom-bb/+/32414
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I39c27caeff0ccd08d8d8b5fcba5a1d69238d53ca
Gerrit-Change-Number: 32414
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 25 Apr 2023 12:41:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment