Jenkins Builder has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29949 )
Change subject: fw/e1-tracer: Initialize IDT82V2081 from within firmware in e1d mode
......................................................................
Patch Set 1:
(3 comments)
File firmware/ice40-riscv/e1-tracer/idt82v2081_no2spi.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-644):
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29949/comment/7851a92d_4d3e…
PS1, Line 32: { .data = (void*)&cmd, .len = 1, .read = false, .write = true, },
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-644):
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29949/comment/18e61d14_521f…
PS1, Line 33: { .data = (void*)&rv, .len = 1, .read = true, .write = false, },
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-644):
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29949/comment/d1761175_8dc0…
PS1, Line 44: { .data = (void*)cmd, .len = 2, .read = false, .write = true, },
"(foo*)" should be "(foo *)"
--
To view, visit
https://gerrit.osmocom.org/c/osmo-e1-hardware/+/29949
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: Id2217ff4573c4eebd816318128f256e85fb3c3bd
Gerrit-Change-Number: 29949
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Tue, 01 Nov 2022 15:45:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment