Attention is currently required from: neels, laforge, pespin.
iedemam has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )
Change subject: WIP: New stats for lchan life duration.
......................................................................
Patch Set 7:
(3 comments)
Patchset:
PS7:
Ooops, I missed these review items.
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/783258a7_3c001f69
PS4, Line 3830: vty_out(vty, " Channel Activations : %"PRIu64"
TCH", activations_tch);
Uhm sounds like I missed that part, I was just
focusing on the formatting. […]
addressed
File src/osmo-bsc/bts_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/93ccaae5_04664224
PS5, Line 3831: vty_out(vty," TCH %"PRIu64"",
activations_tch);
This tabulation looks really big, it probably needs to
be " ".
addressed
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/27081
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I1b0670c47cb5e0b7776eda89d1e71545ba0e3347
Gerrit-Change-Number: 27081
Gerrit-PatchSet: 7
Gerrit-Owner: iedemam <michael(a)kapsulate.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 09 Feb 2022 09:40:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: iedemam <michael(a)kapsulate.com>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment