Attention is currently required from: Hoernchen.
Jenkins Builder has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435?usp=email )
Change subject: errata 2.6.10 ......................................................................
Patch Set 2:
(17 comments)
File gcc/gcc/startup_same54.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/f9513c64_380102b5... : PS2, Line 671: __attribute__((naked,noreturn)) void Reset_Handler(void) space required after that ',' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/b9e523d4_a7bbfa73... : PS2, Line 675: __asm volatile ( please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/9f3450e9_d3b59e8c... : PS2, Line 676: "movs r0, #0\n" code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/f1bc6e7a_2a27b9cf... : PS2, Line 676: "movs r0, #0\n" please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/b9f4216f_a41c6e39... : PS2, Line 677: "ldr r1, =0x40002000\n" code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/f4f6196e_f64c1611... : PS2, Line 677: "ldr r1, =0x40002000\n" please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/0084195f_cb5e315d... : PS2, Line 678: "strb r0, [r1]\n" code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/95e8ba0a_acb7e4c4... : PS2, Line 678: "strb r0, [r1]\n" please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/0ddf0129_0394e01f... : PS2, Line 679: "bl _Reset_Handler\n" code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/e22faafd_8a63f62d... : PS2, Line 679: "bl _Reset_Handler\n" please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/12d30ccf_1ac897cb... : PS2, Line 680: ::: "r0", "r1", "memory" code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/61b684c9_b6b9cd12... : PS2, Line 680: ::: "r0", "r1", "memory" please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/3457724e_e7967689... : PS2, Line 681: ); please, no spaces at the start of a line
File usb_flash_main.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/5c93adda_d7369bd8... : PS2, Line 136: bool startup_wdt_inactive = _user_area_read_bits((void*)NVMCTRL_USER, 62, 1) != 1; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/f1567b46_20143767... : PS2, Line 137: if (chiprev_lower_revG && startup_wdt_inactive) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/eb80e406_f70db584... : PS2, Line 139: _user_area_write_bits((void*)NVMCTRL_USER, 50, 0, 4); "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21267): https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/39435/comment/07d9faaa_eca33b72... : PS2, Line 140: _user_area_write_bits((void*)NVMCTRL_USER, 62, 1, 1); "(foo*)" should be "(foo *)"