[M] Change in osmo-pcu[master]: rcv_control_ack(): Improve logging of confirmation of Pkt Dl/Ul Ass

31 Jul 2024

pespin has uploaded this change for review. (
https://gerrit.osmocom.org/c/osmo-pcu/+/37672?usp=email )


Change subject: rcv_control_ack(): Improve logging of confirmation of Pkt Dl/Ul Ass
......................................................................

rcv_control_ack(): Improve logging of confirmation of Pkt Dl/Ul Ass

This allows tracking which TBF is used to assigned the new TBF.

Change-Id: I1f438cc31ceea24286a914801d3746f577385bfc
---
M src/pdch.cpp
M tests/tbf/TbfTest.err
2 files changed, 34 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/72/37672/1

diff --git a/src/pdch.cpp b/src/pdch.cpp
index 7ff1c7e..3cba690 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -389,7 +389,6 @@
 				osmo_fsm_inst_state_name(tbf_ul_ass_fi(tbf)));
 			return;
 		}
-		LOGPTBF(tbf, LOGL_DEBUG, "[DOWNLINK] UPLINK ASSIGNED\n");
 		pdch_ulc_release_fn(ulc, fn);
 		if (tbf_direction(tbf) == GPRS_RLCMAC_DL_TBF)
 			tbf->n_reset(N3105);
@@ -397,10 +396,12 @@
 
 		new_tbf = ms_ul_tbf(ms);
 		if (!new_tbf) {
-			LOGPDCH(this, DRLCMAC, LOGL_ERROR, "Got ACK, but UL "
-				"TBF is gone TLLI=0x%08x\n", tlli);
+			LOGPDCH(this, DRLCMAC, LOGL_ERROR,
+				"Got PKT_CTRL_ACK (UL_ASS) from %s, but UL TBF is gone (TLLI=0x%08x)\n",
+				tbf_name(tbf), tlli);
 			return;
 		}
+		LOGPTBF(tbf, LOGL_DEBUG, "Got PKT_CTRL_ACK confirming assignment of %s\n",
tbf_name(new_tbf));
 
 		osmo_fsm_inst_dispatch(new_tbf->state_fi, TBF_EV_ASSIGN_ACK_PACCH, NULL);
 		/* there might be LLC packets waiting in the queue, but the DL
@@ -417,7 +418,6 @@
 				osmo_fsm_inst_state_name(tbf_dl_ass_fi(tbf)));
 			return;
 		}
-		LOGPTBF(tbf, LOGL_DEBUG, "[UPLINK] DOWNLINK ASSIGNED\n");
 		pdch_ulc_release_fn(ulc, fn);
 		if (tbf_direction(tbf) == GPRS_RLCMAC_DL_TBF)
 			tbf->n_reset(N3105);
@@ -425,10 +425,12 @@
 
 		new_tbf = ms_dl_tbf(ms);
 		if (!new_tbf) {
-			LOGPDCH(this, DRLCMAC, LOGL_ERROR, "Got ACK, but DL "
-				"TBF is gone TLLI=0x%08x\n", tlli);
+			LOGPDCH(this, DRLCMAC, LOGL_ERROR,
+				"Got PKT_CTRL_ACK (DL_ASS) from %s, but DL TBF is gone (TLLI=0x%08x)\n",
+				tbf_name(tbf), tlli);
 			return;
 		}
+		LOGPTBF(tbf, LOGL_DEBUG, "Got PKT_CTRL_ACK confirming assignment of %s\n",
tbf_name(new_tbf));
 		if ((tbf->state_is(TBF_ST_WAIT_RELEASE) ||
 		     tbf->state_is(TBF_ST_WAIT_REUSE_TFI)) &&
 		    tbf->direction == new_tbf->direction)
diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err
index fdaf917..a012989 100644
--- a/tests/tbf/TbfTest.err
+++ b/tests/tbf/TbfTest.err
@@ -2719,9 +2719,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
@@ -2843,9 +2843,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
@@ -2903,9 +2903,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654288 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654288 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} FN=2654288 Rx Packet Control
Ack (reason=DL_ASS)
-TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} [UPLINK] DOWNLINK ASSIGNED
 DL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: Received Event
RX_ASS_CTRL_ACK
 DL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} Got PKT_CTRL_ACK confirming
assignment of TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}
 DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: Received Event
ASSIGN_ACK_PACCH
 DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Expiring FN=2654288 but previous FN=2654279 is still reserved!
@@ -3030,9 +3030,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654361 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654361 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN} FN=2654361 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN}
 UL_TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-1:G:TLLI-0xf5667788){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Expiring FN=2654361 but previous FN=2654353 is still reserved!
@@ -3181,9 +3181,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
@@ -3300,9 +3300,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654340 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654340 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} FN=2654340 Rx Packet Control
Ack (reason=UL_ASS)
-TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: Received Event
RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming
assignment of TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: Received Event
ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 [DL] algo A <multi> (suggested TRX: 0): Alloc start
@@ -3421,9 +3421,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
@@ -3624,9 +3624,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:G:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
@@ -3724,9 +3724,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654288 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654288 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} FN=2654288 Rx Packet Control
Ack (reason=DL_ASS)
-TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} [UPLINK] DOWNLINK ASSIGNED
 DL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: Received Event
RX_ASS_CTRL_ACK
 DL_ASS_TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){FLOW} Got PKT_CTRL_ACK confirming
assignment of TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}
 DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: Received Event
ASSIGN_ACK_PACCH
 DL_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Expiring FN=2654288 but previous FN=2654279 is still reserved!
@@ -4452,9 +4452,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654413 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654413 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} FN=2654413 Rx Packet
Control Ack (reason=DL_ASS)
-TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} [UPLINK] DOWNLINK
ASSIGNED
 DL_ASS_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: Received Event
RX_ASS_CTRL_ACK
 DL_ASS_TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} Got PKT_CTRL_ACK
confirming assignment of TBF(DL:TFI-0-0-1:G:IMSI-0011223344:TLLI-0xf1223344){ASSIGN}
 TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE} free
 PDCH(bts=0,trx=0,ts=7) Detaching
TBF(DL:TFI-0-0-0:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE}, 2 TBFs, USFs = 01, TFIs
= 00000003.
 MS(IMSI-0011223344:TLLI-0xf1223344:TA-7:MSCLS-1-0:UL:DL) Detaching TBF:
TBF(DL:G:IMSI-0011223344:TLLI-0xf1223344){WAIT_RELEASE}
@@ -4878,9 +4878,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
@@ -5010,9 +5010,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
@@ -9282,9 +9282,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got CS-1 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=184
@@ -9516,9 +9516,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got MCS-4 RLC block: R=1, SI=0, TFI=0, CPS=5, RSB=0, rc=385
@@ -10048,9 +10048,9 @@
 PDCH(bts=0,trx=0,ts=7) FN=2654283 +++++++++++++++++++++++++ RX : Uplink Control Block
+++++++++++++++++++++++++
 PDCH(bts=0,trx=0,ts=7) FN=2654283 ------------------------- RX : Uplink Control Block
-------------------------
 TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} FN=2654283 Rx Packet Control Ack
(reason=UL_ASS)
-TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} [DOWNLINK] UPLINK ASSIGNED
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: Received Event RX_ASS_CTRL_ACK
 UL_ASS_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){WAIT_ACK}: state_chg to NONE
+TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN} Got PKT_CTRL_ACK confirming assignment of
TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: Received Event ASSIGN_ACK_PACCH
 UL_TBF(UL:TFI-0-0-0:E:TLLI-0xf1223344){ASSIGN}: state_chg to FLOW
 PDCH(bts=0,trx=0,ts=7) Got MCS-4 RLC block: R=0, SI=0, TFI=0, CPS=0, RSB=0, rc=385

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37672?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1f438cc31ceea24286a914801d3746f577385bfc
Gerrit-Change-Number: 37672
Gerrit-PatchSet: 1
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: newchange



    

2025

2024

2023

2022

[M] Change in osmo-pcu[master]: rcv_control_ack(): Improve logging of confirmation of Pkt Dl/Ul Ass