fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/39829?usp=email )
Change subject: rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC ......................................................................
rsl: rsl_rx_chan_activ(): set TA=0 if not indicated by the BSC
Otherwise the TA loop would end up using whatever value was set previously. Let's assume TA=0 if not indicated by the BSC.
Change-Id: I83f26ff06cebdfe8d4e75944f496e9678310e2a2 --- M src/common/rsl.c 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/29/39829/1
diff --git a/src/common/rsl.c b/src/common/rsl.c index 7931a17..1104ef8 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -2064,6 +2064,8 @@ /* 9.3.24 Timing Advance */ if (TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1)) lchan->ta_ctrl.current = *TLVP_VAL(&tp, RSL_IE_TIMING_ADVANCE); + else /* assume TA=0 if not indicated by the BSC */ + lchan->ta_ctrl.current = 0;
/* 9.3.31 (TLV) MS Power Parameters IE (vendor specific) */ if ((ie = TLVP_GET(&tp, RSL_IE_MS_POWER_PARAM)) != NULL) {