Attention is currently required from: pespin.
fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481?usp=email )
Change subject: asp: Introduce support to configure and enable TCP keep-alive ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File src/ss7_asp.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/a71e40f6_ac62ee... : PS2, Line 800: rc = You're assigning a value to `rc`, but then after the `switch` it gets overwritten.
File src/ss7_asp_vty.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/40481/comment/15830fce_6cc78d... : PS2, Line 512: "num-ostreams" Where these values are coming from? They're not part of `ASP_TCP_PARAM_KEEPALIVE_CFG_FIELDS`.