Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. (
https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email )
Change subject: Introduce osmo-udp-responder
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
a
File src/osmo-udp-responder/udp_responder.c:
https://gerrit.osmocom.org/c/upf-benchmark/+/38328/comment/ba3595cb_6584a16… :
PS1, Line 55: st
if we implement our own cmdline parser rather than
using glibc getopt_long, I would expect at least […]
also, as we are about to
introduce more tools here: why is that parser not in a separate .c/.h file? Is it only
needed here?
--
To view, visit
https://gerrit.osmocom.org/c/upf-benchmark/+/38328?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: upf-benchmark
Gerrit-Branch: master
Gerrit-Change-Id: I9edc2e3e1e41767673bcf96f1fe97fa4bf6d60f7
Gerrit-Change-Number: 38328
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 07 Oct 2024 06:01:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>