Attention is currently required from: pespin.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34242 )
Change subject: write_queue: Introduce API osmo_wqueue_set_max_length() ......................................................................
Patch Set 1:
(1 comment)
File include/osmocom/core/write_queue.h:
https://gerrit.osmocom.org/c/libosmocore/+/34242/comment/bf2120ab_f44b7b4f PS1, Line 51: void osmo_wqueue_set_max_length(struct osmo_wqueue *queue, unsigned int max_length); I'm not sure how useful this is, given that the 'struct osmo_wqueue' is public a few lines above. Yes, in general more encapsulation would be nice - but for backwards compatibility we can never move those public structs into private headers, and hence they will always remain public.