Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34242 ) Change subject: write_queue: Introduce API osmo_wqueue_set_max_length() ...................................................................... Patch Set 1: (1 comment) File include/osmocom/core/write_queue.h: https://gerrit.osmocom.org/c/libosmocore/+/34242/comment/bf2120ab_f44b7b4f PS1, Line 51: void osmo_wqueue_set_max_length(struct osmo_wqueue *queue, unsigned int max_length); I'm not sure how useful this is, given that the 'struct osmo_wqueue' is public a few lines above. Yes, in general more encapsulation would be nice - but for backwards compatibility we can never move those public structs into private headers, and hence they will always remain public. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34242 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia1b138ed622f5efaa761bd9fa062b25b598f356f Gerrit-Change-Number: 34242 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 29 Aug 2023 17:12:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment