Change in osmo-hnbgw[master]: add option to send SCCP CR without payload

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 ) Change subject: add option to send SCCP CR without payload ...................................................................... Patch Set 2: (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/3ca86ce9_9abe04d1 PS1, Line 27: a separate SCCP CR without payload. Sure. With a RANAP payload size, a user can still experiment with a bound below which to still avoid the additional CR->CC roundtrip, so I thought this is more interesting than a boolean... Would be trivial to change this to a boolean flag, basically shows only in the cfg. Opinions anyone else? File include/osmocom/hnbgw/context_map.h: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/0d4d8db2_dbf030b4 PS1, Line 42: RUA_CN_DomainIndicator_t cached_domain_indicator; I guess so. rua_to_scu() wants a RUA_CN_ComainIndicator_t arg, so I just added it ... Ok, so indeed it seems a hnbgw_context_map is always separate for CS and PS, so can replace with (is_ps ? RUA_CN_DomainIndicator_ps_domain : RUA_CN_DomainIndicator_cs_domain) File src/osmo-hnbgw/hnbgw.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/ecca58f7_a2c6dd66 PS1, Line 93: gw->config.max_sccp_cr_payload_len = 999999; on the VTY, we often use max values like 99999, that's the only reason. Given a usual MTU is like 1500, I assume 999k is sufficiently close to infinity. File src/osmo-hnbgw/hnbgw_rua.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230/comment/1d4d6c04_b1995421 PS1, Line 274: if (data && len && map && !map->is_ps && !release_context_map) { Because ranap_cn_rx_co_decode() crashes when there is no payload data. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/28230 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If0c5c0a76e5230bf22871f527dcb2dbdf34d7328 Gerrit-Change-Number: 28230 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 07 Jun 2022 16:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment