Attention is currently required from: fixeria, laforge, lynxis lazus, pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email )
Change subject: gsup.h: define newly added PCO IE
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/gsm/gsup.c:
https://gerrit.osmocom.org/c/libosmocore/+/36024/comment/1d3519b6_217b34ec
PS3, Line 881: msgb_tlv_put(msg, OSMO_GSUP_PCO_IE, gsup_msg->pco_len,
gsup_msg->pco);
Yeah I think we can check for pco_len <= 251 here.
I think also that this makes sense. (I am not aware of this, in case the length is
something the API user has to set consciously, then an OSMO_ASSERT might also make
sense.)
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/36024?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I0f9de90c7c67fe194b441a9d118eba70f09afb5e
Gerrit-Change-Number: 36024
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Comment-Date: Tue, 27 Feb 2024 15:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment