Attention is currently required from: lynxis lazus, msuraev.
daniel has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714 )
Change subject: gbproxy_vty: Add commands to list Cell/BVC of an NSE
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS3:
Re-adding +2 from before
File src/gb_proxy_vty.c:
https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/d367e82b_d0b85d46
PS2, Line 543: int i;
I don't completely disagree, but in the macro bkt
is initialized to 0 and checked against ARRAY_SIZE […]
Done
https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714/comment/a3aaa1df_e993d9d5
PS2, Line 587: int i;
Same as above.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-gbproxy/+/29714
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gbproxy
Gerrit-Branch: master
Gerrit-Change-Id: I10c6d3f59681ec6dc98f1a3b023af446cc2a1c12
Gerrit-Change-Number: 29714
Gerrit-PatchSet: 3
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: msuraev <msuraev(a)sysmocom.de>
Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Attention: msuraev <msuraev(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 20 Oct 2022 14:10:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de>
Gerrit-MessageType: comment