Attention is currently required from: fixeria, jolly, lynxis lazus, matanp, neels.
osmith has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email )
Change subject: vlr: Stop silent call before deduping subscribers
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Patchset:
PS2:
We already have a +1 from laforge and previously from jolly (before gsm_silent_call_is_ongoing was added). It looks like we don't have a better solution than this and it fixes running into an assert, so I'm adding +2 and merging it. Thanks @matan1008@gmail.com!
File src/libvlr/vlr.c:
https://gerrit.osmocom.org/c/osmo-msc/+/41131/comment/2ec1293c_beb9e04d?usp=... :
PS1, Line 651: gsm_silent_call_stop(
I added a check to make sure we stop only ongoing transactions
thanks!
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/41131?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: If23f8b0e42d4a3a8bf1c8f5ca81b045834b6cccd
Gerrit-Change-Number: 41131
Gerrit-PatchSet: 2
Gerrit-Owner: matanp
matan1008@gmail.com
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: jolly
andreas@eversberg.eu
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Reviewer: neels
nhofmeyr@sysmocom.de
Gerrit-Reviewer: osmith
osmith@sysmocom.de
Gerrit-CC: pespin
pespin@sysmocom.de
Gerrit-Attention: jolly
andreas@eversberg.eu
Gerrit-Attention: neels
nhofmeyr@sysmocom.de
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: matanp
matan1008@gmail.com
Gerrit-Comment-Date: Fri, 24 Oct 2025 06:22:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly
andreas@eversberg.eu
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: matanp
matan1008@gmail.com
