Attention is currently required from: laforge, neels, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415?usp=email )
Change subject: sip: tweak failure reporting for SIP messages ......................................................................
Patch Set 2:
(1 comment)
File sip/SIP_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34415/comment/8ec3bd36_cf136... PS1, Line 195: og("FAIL: expected SIP message ", sip_expect); : setverdict(fail, "Received unexpected SIP message");
Yeah, "f_shutdown(__FILE__, __LINE__, fail, log2str(...))" is the usual construct. […]
FYI, you can still do it like this:
``` setverdict(fail, "Received unexpected SIP message, expected: ", sip_expect); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); ```
Personally I tend to use this combination, because `setverdict` is setting the verdict and `f_shutdown` is doing the shutdown. I don't like setting the verdict using `f_shutdown` because it requires using `log2str`.