Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41713?usp=email )
Change subject: pysim/log: also accept ANSI strings to specify the log message colors ......................................................................
Patch Set 1:
(1 comment)
File pySim/log.py:
https://gerrit.osmocom.org/c/pysim/+/41713/comment/afb6c19b_18ec7206?usp=ema... : PS1, Line 111: if type(color) is str: I think isinstance(color, str) would be the more appropriate, as the above only matches if it's *exactly* a str, while failing on str-derived subclasses. See https://switowski.com/blog/type-vs-isinstance/#difference-between-isinstance...