[M] Change in osmocom-bb[master]: trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34139 ) Change subject: trxcon: properly handle PDCH slotmask in UL/DL TBF CFG.Req ...................................................................... Patch Set 2: Code-Review-1 (3 comments) File include/l1gprs.h: https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/ff0b21e6_228efa91 PS2, Line 37: void *priv The `priv` is already accessible via `gprs->priv`, this argument can be removed. https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/525c012d_572ad765 PS2, Line 48: changed_cb It's currently way too generic: "something has changed, figure out what exactly yourself by checking the internal state". I suggest adding a more specific callback: ``` pdch_state_cb(struct l1gprs_pdch *pdch, bool active) ``` and call it either when the total TBF count becomes higher than 0 (`active=true`), or when it becomes 0 again (`active=true`). This will hide the implementation details a bit and eliminate the need for the API user to iterate over all PDCHs looking for potential changes. Also, a comment documenting this new field is missing. File src/host/trxcon/src/trxcon_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/34139/comment/7605072d_e32e77a3 PS1, Line 577: handle_tbf_cfg_req(trxcon); I see you already implemented this in the new patchset revision. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/34139 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4c2ff25217fba0b6b4704f023071b86ed9afb55c Gerrit-Change-Number: 34139 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Aug 2023 19:34:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment