Attention is currently required from: pespin.

Patch set 2:Code-Review -1

View Change

3 comments:

• File include/l1gprs.h:

  • Patch Set #2, Line 37: void *priv

    The `priv` is already accessible via `gprs->priv`, this argument can be removed.

  • Patch Set #2, Line 48: changed_cb

    It's currently way too generic: "something has changed, figure out what exactly yourself by checking the internal state". I suggest adding a more specific callback:

    ```
    pdch_state_cb(struct l1gprs_pdch *pdch, bool active)
    ```

    and call it either when the total TBF count becomes higher than 0 (`active=true`), or when it becomes 0 again (`active=true`). This will hide the implementation details a bit and eliminate the need for the API user to iterate over all PDCHs looking for potential changes.

    Also, a comment documenting this new field is missing.

• File src/host/trxcon/src/trxcon_fsm.c:

  • Patch Set #1, Line 577: handle_tbf_cfg_req(trxcon);

    Using trxcon specific API from l1gprs is not an option. […]

    I see you already implemented this in the new patchset revision.

To view, visit change 34139. To unsubscribe, or for help writing mail filters, visit settings.