Attention is currently required from: jolly, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email )
Change subject: Add LLC and HLC transcoding to MNCC transcoding functions
......................................................................
Patch Set 2:
(1 comment)
File src/gsm/gsm48_ie.c:
https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/1284efa6_c3f4a299
PS2, Line 413: gsm48_encode_highl_compat
The `encode`/`decode` in symbol names creates a false impression that these functions
actually `encode`/`decode` from/to an abstract representation. We may need the actual
encoding/decoding on the MS side (osmocom-bb). Maybe call it pack/unpack or wrap/unwrap to
avoid confusion?
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ia6a2159ecf810a02f85b558026edf20b934567de
Gerrit-Change-Number: 35391
Gerrit-PatchSet: 2
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 19 Dec 2023 16:53:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment