Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/28782 )
Change subject: in sdp logging: add payload type number like 'AMR#111'
......................................................................
Patch Set 3:
(2 comments)
File src/libmsc/sdp_msg.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28782/comment/f11ad3cf_86cf2964
PS1, Line 512: OSMO_STRBUF_PRINTF(sb, "#%d", codec->payload_type);
thx, applied this review
Done
File src/libmsc/sdp_msg.c:
https://gerrit.osmocom.org/c/osmo-msc/+/28782/comment/d71a9907_5f24d2d4
PS3, Line 516: OSMO_STRBUF_PRINTF(sb, "#%d", codec->payload_type);
does it makes sense that this is a %d and not a %u?
Ack
--
To view, visit
https://gerrit.osmocom.org/c/osmo-msc/+/28782
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Icbb4e89ce2947bf787c3ee14e3e115d406e43de2
Gerrit-Change-Number: 28782
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Jul 2022 14:59:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment