Attention is currently required from: jolly.
fixeria has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188?usp=email )
Change subject: MME-Tests: Add tests for emergency cappability indication ......................................................................
Patch Set 1:
(4 comments)
File mme/ConnHdlr.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/979eca67_b188c... : PS1, Line 344: if (lengthof(enl_tlv.emergencyNumberList) != g_pars.emerg_pars.numbers) { I see you're doing a lot of "manual" matching here. Why not defining templates for `EmergencyNumber` and `EmergencyNumberList`? This way you could have a template in `EmergParams` and simply do `match(attach_accept.emergencyNumberList, template)` here.
File mme/MME_Tests_emergency.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/fb0be5fe_a277e... : PS1, Line 3: SGsAP related procedures copy-paste
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/54805032_f6b11... : PS1, Line 3: in in fixme
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41188/comment/493e73f5_4cb4f... : PS1, Line 4: 2025 Andreas Eversberg aeversberg@sysmocom.de I believe the copyright holder should be sysmocom.